Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify password element #82

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Simplify password element #82

wants to merge 8 commits into from

Conversation

lippserd
Copy link
Member

@lippserd lippserd commented Oct 24, 2022 •
edited
Loading

The previous implementation was far too complex.

@cla-bot cla-bot bot added the cla/signed label Oct 24, 2022
@lippserd lippserd force-pushed the password-element branch 4 times, most recently from 111b6c2 to 5932e71 Compare October 24, 2022 20:59
@lippserd lippserd marked this pull request as ready for review November 9, 2022 08:37
@lippserd lippserd added this to the v0.7.0 milestone Nov 9, 2022
@lippserd lippserd removed this from the v0.7.0 milestone Feb 22, 2023
lippserd and others added 8 commits February 24, 2023 09:14
@lippserd @raviks789
Test password element
fdc1603
@lippserd @raviks789
Revert "Introduce PasswordElement class"
f5afa15 
This reverts commit ec26482.
@lippserd @raviks789
Revert "Introduce ON_VALIDATE form event"
87b4639 
This reverts commit 9c82c99.
@lippserd @raviks789
Revert "Implement ValueCandidates interface"
0fdaa8f 
This reverts commit e2576c6.
@lippserd @raviks789
Revert "Introduce ValueCandidates interface"
346b983 
This reverts commit ad6f4c9.
@lippserd @raviks789
Add password element
df0b249
@nilmerg @raviks789
PasswordElementTest: Add additional cases, improve others
f1bc4b5 
I've adjusted the other tests as well. They resemble the
chronological order better that is usually in effect. This
also makes the first test run without the changes in this
PR.
@raviks789
PasswordElementTest: Test case with autosubmit element in Fieldset
f9cc245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhabteab yhabteab Awaiting requested review from yhabteab

@nilmerg nilmerg Awaiting requested review from nilmerg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla/signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lippserd @nilmerg @raviks789